-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix DAG.access_control can't sync when clean access_control #30116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
huymq1710
wants to merge
12
commits into
apache:main
from
huymq1710:sync-dag-to-db-when-clear-access_control
Closed
Fix DAG.access_control can't sync when clean access_control #30116
huymq1710
wants to merge
12
commits into
apache:main
from
huymq1710:sync-dag-to-db-when-clear-access_control
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #25149
needs_permslogical error.access_controlis empty, permission-sync is skipped entirely. I think it should check whether there’s existing permission configurations and reset those if needed instead.This is my first PR, so if there is anything else I should do, please let me know. Hope to contribute more for Airflow.