Skip to content

Conversation

@huymq1710
Copy link
Contributor

@huymq1710 huymq1710 commented Mar 15, 2023

closes: #25149

  • fix needs_perms logical error.
  • If a DAG’s access_control is empty, permission-sync is skipped entirely. I think it should check whether there’s existing permission configurations and reset those if needed instead.

This is my first PR, so if there is anything else I should do, please let me know. Hope to contribute more for Airflow.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Mar 15, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 15, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal changed the title Fix apache#25149 DAG.access_control can't sync when clean access_control Fix DAG.access_control can't sync when clean access_control Mar 15, 2023
@huymq1710 huymq1710 requested review from jedcunningham and removed request for XD-DENG, ashb, jhtimmins and kaxil March 17, 2023 18:58
@eladkal eladkal added this to the Airflow 2.5.3 milestone Mar 22, 2023
@huymq1710 huymq1710 marked this pull request as draft March 22, 2023 13:05
@huymq1710 huymq1710 marked this pull request as ready for review March 22, 2023 14:43
@huymq1710 huymq1710 marked this pull request as draft March 23, 2023 01:56
@huymq1710 huymq1710 marked this pull request as ready for review March 23, 2023 03:05
@huymq1710 huymq1710 requested a review from jedcunningham March 23, 2023 05:42
@huymq1710 huymq1710 marked this pull request as draft March 27, 2023 15:13
@eladkal eladkal modified the milestones: Airflow 2.5.3, Airflow 2.5.4 Mar 27, 2023
@huymq1710 huymq1710 closed this Mar 28, 2023
@eladkal eladkal removed this from the Airflow 2.5.4 milestone Apr 4, 2023
@huymq1710 huymq1710 deleted the sync-dag-to-db-when-clear-access_control branch April 6, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DAG.access_control can't sync when clean access_control

3 participants