Skip to content

Conversation

@ferruzzi
Copy link
Contributor

Completes the Breeze OpenTelemetry integration and adds a banner to the UI indicating it is currently experimental.

(Final?) PR to add some groundwork to allow OTel support. Follow-up to #29521

After getting a working working PoC, the Breeze integration needed a tweak to work correctly. Changes have been tested against a working* proof-of-concept which can be found here for now if anyone wants to try them out.

*So far only a subset of metrics are working in that POC, but the ones that ARE working are working end to end.

Major changes:

  • Corrects the OpenTelemetry Collector port to 8889 instead of 8888
  • Adds OTel values to the Airflow Config
  • Adds the required new Environment Variables tot he integration's docker-compose file to set those config values
  • If Otel is enabled, adds a banner to the UI showing that OTel support is currently experimental
  • Edits to scripts/ci/docker-compose/otel-collector-config.yml to get it working as expected and trim some fat

Minor Changes:

  • Rephrasing some docs
  • Cleans up some unnecessary port forwarding in the integration's docker-compose file
  • Cleans up some extensions in the OTel collector config file that ended up being unnecessary

@boring-cyborg boring-cyborg bot added area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation labels Mar 16, 2023
@ferruzzi ferruzzi force-pushed the ferruzzi/otel/m1-fix-breeze-integ branch from f43fb08 to e3fa3c7 Compare March 17, 2023 00:00
Added "otel" to the dictionary and changed "millis" to "milliseconds"
@ferruzzi ferruzzi force-pushed the ferruzzi/otel/m1-fix-breeze-integ branch from 89a9969 to 3bd655e Compare March 17, 2023 03:41
<a href={{ get_docs_url("executor/index.html") }}><b>Click here</b></a> for more information.
{% endcall %}
{% endif %}
{% if otel_on | default(false) %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@potiuk potiuk merged commit 698773b into apache:main Mar 17, 2023
@pierrejeambrun pierrejeambrun added this to the Airflow 2.5.3 milestone Mar 22, 2023
@pierrejeambrun pierrejeambrun added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 22, 2023
ephraimbuddy added a commit to astronomer/airflow that referenced this pull request Aug 18, 2023
The otel was 2.6.0 as can be seen here: apache#30160 and
the internal api and related were 2.6.0 even though they were under a flag. These need to be updated
except we want to modify the check tool to skip these ones
ephraimbuddy added a commit that referenced this pull request Aug 18, 2023
The otel was 2.6.0 as can be seen here: #30160 and
the internal api and related were 2.6.0 even though they were under a flag. These need to be updated
except we want to modify the check tool to skip these ones
ephraimbuddy added a commit that referenced this pull request Aug 28, 2023
The otel was 2.6.0 as can be seen here: #30160 and
the internal api and related were 2.6.0 even though they were under a flag. These need to be updated
except we want to modify the check tool to skip these ones

(cherry picked from commit ba4f541)
@ferruzzi ferruzzi changed the title Completes the Breeze OTel integration and adds a banner to the UI [AIP-49] Completes the Breeze OTel integration and adds a banner to the UI Oct 27, 2023
ahidalgob pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 15, 2024
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and
the internal api and related were 2.6.0 even though they were under a flag. These need to be updated
except we want to modify the check tool to skip these ones

(cherry picked from commit ba4f541fba656acb6c35469c97a1e1bfc79f2d96)

GitOrigin-RevId: 3f8c35246fa2de012a4b8f1af3c1fb2afba2a2fe
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 18, 2024
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and
the internal api and related were 2.6.0 even though they were under a flag. These need to be updated
except we want to modify the check tool to skip these ones

GitOrigin-RevId: ba4f541fba656acb6c35469c97a1e1bfc79f2d96
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 19, 2024
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and
the internal api and related were 2.6.0 even though they were under a flag. These need to be updated
except we want to modify the check tool to skip these ones

GitOrigin-RevId: ba4f541fba656acb6c35469c97a1e1bfc79f2d96
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 8, 2024
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and
the internal api and related were 2.6.0 even though they were under a flag. These need to be updated
except we want to modify the check tool to skip these ones

GitOrigin-RevId: ba4f541fba656acb6c35469c97a1e1bfc79f2d96
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 4, 2025
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and
the internal api and related were 2.6.0 even though they were under a flag. These need to be updated
except we want to modify the check tool to skip these ones

GitOrigin-RevId: ba4f541fba656acb6c35469c97a1e1bfc79f2d96
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 25, 2025
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and
the internal api and related were 2.6.0 even though they were under a flag. These need to be updated
except we want to modify the check tool to skip these ones

GitOrigin-RevId: ba4f541fba656acb6c35469c97a1e1bfc79f2d96
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 20, 2025
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and
the internal api and related were 2.6.0 even though they were under a flag. These need to be updated
except we want to modify the check tool to skip these ones

GitOrigin-RevId: ba4f541fba656acb6c35469c97a1e1bfc79f2d96
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 18, 2025
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and
the internal api and related were 2.6.0 even though they were under a flag. These need to be updated
except we want to modify the check tool to skip these ones

GitOrigin-RevId: ba4f541fba656acb6c35469c97a1e1bfc79f2d96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants