-
Notifications
You must be signed in to change notification settings - Fork 16.4k
[AIP-49] Completes the Breeze OTel integration and adds a banner to the UI #30160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
potiuk
merged 2 commits into
apache:main
from
aws-mwaa:ferruzzi/otel/m1-fix-breeze-integ
Mar 17, 2023
Merged
[AIP-49] Completes the Breeze OTel integration and adds a banner to the UI #30160
potiuk
merged 2 commits into
apache:main
from
aws-mwaa:ferruzzi/otel/m1-fix-breeze-integ
Mar 17, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f43fb08 to
e3fa3c7
Compare
…icating it is currently experimental.
Added "otel" to the dictionary and changed "millis" to "milliseconds"
89a9969 to
3bd655e
Compare
potiuk
reviewed
Mar 17, 2023
| <a href={{ get_docs_url("executor/index.html") }}><b>Click here</b></a> for more information. | ||
| {% endcall %} | ||
| {% endif %} | ||
| {% if otel_on | default(false) %} |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
potiuk
approved these changes
Mar 17, 2023
ephraimbuddy
added a commit
to astronomer/airflow
that referenced
this pull request
Aug 18, 2023
The otel was 2.6.0 as can be seen here: apache#30160 and the internal api and related were 2.6.0 even though they were under a flag. These need to be updated except we want to modify the check tool to skip these ones
ephraimbuddy
added a commit
that referenced
this pull request
Aug 18, 2023
The otel was 2.6.0 as can be seen here: #30160 and the internal api and related were 2.6.0 even though they were under a flag. These need to be updated except we want to modify the check tool to skip these ones
ahidalgob
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 15, 2024
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and the internal api and related were 2.6.0 even though they were under a flag. These need to be updated except we want to modify the check tool to skip these ones (cherry picked from commit ba4f541fba656acb6c35469c97a1e1bfc79f2d96) GitOrigin-RevId: 3f8c35246fa2de012a4b8f1af3c1fb2afba2a2fe
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 18, 2024
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and the internal api and related were 2.6.0 even though they were under a flag. These need to be updated except we want to modify the check tool to skip these ones GitOrigin-RevId: ba4f541fba656acb6c35469c97a1e1bfc79f2d96
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 19, 2024
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and the internal api and related were 2.6.0 even though they were under a flag. These need to be updated except we want to modify the check tool to skip these ones GitOrigin-RevId: ba4f541fba656acb6c35469c97a1e1bfc79f2d96
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 8, 2024
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and the internal api and related were 2.6.0 even though they were under a flag. These need to be updated except we want to modify the check tool to skip these ones GitOrigin-RevId: ba4f541fba656acb6c35469c97a1e1bfc79f2d96
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 4, 2025
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and the internal api and related were 2.6.0 even though they were under a flag. These need to be updated except we want to modify the check tool to skip these ones GitOrigin-RevId: ba4f541fba656acb6c35469c97a1e1bfc79f2d96
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 25, 2025
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and the internal api and related were 2.6.0 even though they were under a flag. These need to be updated except we want to modify the check tool to skip these ones GitOrigin-RevId: ba4f541fba656acb6c35469c97a1e1bfc79f2d96
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 20, 2025
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and the internal api and related were 2.6.0 even though they were under a flag. These need to be updated except we want to modify the check tool to skip these ones GitOrigin-RevId: ba4f541fba656acb6c35469c97a1e1bfc79f2d96
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 18, 2025
The otel was 2.6.0 as can be seen here: apache/airflow#30160 and the internal api and related were 2.6.0 even though they were under a flag. These need to be updated except we want to modify the check tool to skip these ones GitOrigin-RevId: ba4f541fba656acb6c35469c97a1e1bfc79f2d96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:dev-tools
area:UI
Related to UI/UX. For Frontend Developers.
area:webserver
Webserver related Issues
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
kind:documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the Breeze OpenTelemetry integration and adds a banner to the UI indicating it is currently experimental.
(Final?) PR to add some groundwork to allow OTel support. Follow-up to #29521
After getting a working working PoC, the Breeze integration needed a tweak to work correctly. Changes have been tested against a working* proof-of-concept which can be found here for now if anyone wants to try them out.
*So far only a subset of metrics are working in that POC, but the ones that ARE working are working end to end.
Major changes:
Minor Changes: