Revert fix for on_failure_callback when task receives a SIGTERM #30165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Mar 17, 2023
ephraimbuddy
force-pushed
the
fix-failure-callback
branch
from
23aa472 to
aa03627
Compare
eejbyfeldt
approved these changes
Mar 17, 2023
eejbyfeldt
left a comment
eejbyfeldt
left a comment
There was a problem hiding this comment.
Revert sounds like the right choice to me.
I think it could be nice to add the test cases from: #30146 to prevent similarly bad changes being introduced in the future. But maybe that is better done in a followup PR.
ephraimbuddy
force-pushed
the
fix-failure-callback
branch
from
aa03627 to
5f066f2
Compare
From the comment on exception handling when a task is killed externally we do not handle callback thus the above fix was made in error. Here's the comment on code: for case when task is marked as success/failed externally or dagrun timed out and task is marked as skipped current behavior doesn't hit the callbacks https://github.com/apache/airflow/blob/b65dbaaf3f21ea5396da121bbfa7f895d0ab8516/airflow/models/taskinstance.py#L1468-L1470
ephraimbuddy
force-pushed
the
fix-failure-callback
branch
from
5f066f2 to
ced9f99
Compare
Contributor
Author
Feel free to make the PR once this is merged. Also we can add a comment on the signal handler itself to say that we don't handle callbacks when tasks are marked failed externally |
Member
Good idea. I think that's the super-easy (though temporary) fix. |
eejbyfeldt
reviewed
Mar 17, 2023
Co-authored-by: Emil Ejbyfeldt <eejbyfeldt@liveintent.com>
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Revert fix for on_failure_callback when task receives a SIGTERM From the comment on exception handling when a task is killed externally we do not handle callback thus the above fix was made in error. Here's the comment on code: for case when task is marked as success/failed externally or dagrun timed out and task is marked as skipped current behavior doesn't hit the callbacks https://github.com/apache/airflow/blob/b65dbaaf3f21ea5396da121bbfa7f895d0ab8516/airflow/models/taskinstance.py#L1468-L1470 * Update tests/models/test_taskinstance.py Co-authored-by: Emil Ejbyfeldt <eejbyfeldt@liveintent.com> --------- Co-authored-by: Emil Ejbyfeldt <eejbyfeldt@liveintent.com> (cherry picked from commit 869c1e3)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 24, 2023
* Revert fix for on_failure_callback when task receives a SIGTERM From the comment on exception handling when a task is killed externally we do not handle callback thus the above fix was made in error. Here's the comment on code: for case when task is marked as success/failed externally or dagrun timed out and task is marked as skipped current behavior doesn't hit the callbacks https://github.com/apache/airflow/blob/b65dbaaf3f21ea5396da121bbfa7f895d0ab8516/airflow/models/taskinstance.py#L1468-L1470 * Update tests/models/test_taskinstance.py Co-authored-by: Emil Ejbyfeldt <eejbyfeldt@liveintent.com> --------- Co-authored-by: Emil Ejbyfeldt <eejbyfeldt@liveintent.com> (cherry picked from commit 869c1e3)
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the comment on exception handling when a task is killed externally we do not handle callback thus
the above fix was made in error. Here's the comment on code:
for case when task is marked as success/failed externally
or dagrun timed out and task is marked as skipped
current behavior doesn't hit the callbacks
airflow/airflow/models/taskinstance.py
Lines 1468 to 1470 in b65dbaa
closes: #30146