Skip to content

Conversation

@junho85
Copy link
Contributor

@junho85 junho85 commented Mar 18, 2023

In the DDL generated by DB upgrade, VARCHAR size is 250, but in the upgrading documentation VARCHAR size is 255, so correct it.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

In the DDL generated by DB upgrade, VARCHAR size is 250, but in the upgrading documentation VARCHAR size is 255, so correct it.
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 18, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk merged commit 013490e into apache:main Mar 20, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 20, 2023

Awesome work, congrats on your first merged pull request!

@pierrejeambrun pierrejeambrun added this to the Airflow 2.5.3 milestone Mar 22, 2023
@pierrejeambrun pierrejeambrun added the type:bug-fix Changelog: Bug Fixes label Mar 22, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 23, 2023
In the DDL generated by DB upgrade, VARCHAR size is 250, but in the upgrading documentation VARCHAR size is 255, so correct it.

(cherry picked from commit 013490e)
pierrejeambrun pushed a commit that referenced this pull request Mar 24, 2023
In the DDL generated by DB upgrade, VARCHAR size is 250, but in the upgrading documentation VARCHAR size is 255, so correct it.

(cherry picked from commit 013490e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants