Remove protobuf limitation from eager upgrade #30182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:production-image
Member
Author
|
cc: @lwyszomi |
Member
Author
|
Related to #30067 |
Member
Author
|
cc: @lwyszomi -> until (at least) language is upgraded, the protobuf cannot be removed - but this one shows what needs to be done when it is. https://github.com/apache/airflow/actions/runs/4457252669/jobs/7828319337?pr=30182#step:5:1591 |
Contributor
|
👍 |
Protobuf limitation was added to help pip resolve eager upgrade dependencies, however it is not needed any more.
potiuk
force-pushed
the
remove-protobuf-limitation-for-eager-upgrade
branch
from
b4bc35f to
6b1c4c8
Compare
Member
Author
|
It seems we can now remove protobuf limitation with current dependencies from eager upgrade |
Member
Author
|
This (next to few other changes and finally culminating in #30067 merged, should finally get us out the protobuf conundrum |
potiuk
requested review from
ephraimbuddy,
hussein-awala,
kaxil,
pierrejeambrun and
uranusjr
hussein-awala
approved these changes
Apr 19, 2023
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 23, 2023
Protobuf limitation was added to help pip resolve eager upgrade dependencies, however it is not needed any more. (cherry picked from commit f243a3f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf limitation was added to help pip resolve eager upgrade dependencies, however it is not needed any more.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.