-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add fullname to owner on logging #30185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@potiuk Seems like 1 test out of 40 fails, but I cannot see which. Would you be able to help? |
|
This looks great, but it would be nice to have a means of providing a formatting function in |
|
Instead of changing the meaning of |
|
@uranusjr That's also a solid option. But, would that not require changes to the log table to add in a new column referencing the full name? |
|
Yes it does. Adding a column (with NULL default) is quite cheap, so the question is whether we want to do it. Speaking of that, why do we want the full name here in the first place? Maybe it is easier to change the UI to JOIN the user table instead? |
|
@uranusjr There is a screenshot in my linked issue, the reason is to just make it clear in the Audit logs as to who has done what. At least in our case, it just references the azure ID which doesn't say anything. Could you give me a hint on where to introduce the JOIN? I could take a look at it then. |
|
@uranusjr Actually, figured out the addition of a new field to the log table, I was just overthinking it. I'll put some more into it and return :) |
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
|
Hi @uranusjr, I've commited the suggested change. Is it good to go? |
|
Doc building failure is unrelated. |
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> --------- Co-authored-by: Malthe Borch <mborch@gmail.com> Co-authored-by: eladkal <45845474+eladkal@users.noreply.github.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit a03f6cc)

closes: #29662
This change adds the owner's full name in brackets next to the owner username.