Skip to content

Conversation

@arjunanan6
Copy link
Contributor

@arjunanan6 arjunanan6 commented Mar 19, 2023

closes: #29662

This change adds the owner's full name in brackets next to the owner username.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Mar 19, 2023
@arjunanan6
Copy link
Contributor Author

@potiuk Seems like 1 test out of 40 fails, but I cannot see which. Would you be able to help?

@malthe
Copy link
Contributor

malthe commented Mar 20, 2023

This looks great, but it would be nice to have a means of providing a formatting function in $AIRFLOW_HOME/webserver_config.py.

@uranusjr
Copy link
Member

Instead of changing the meaning of user, it may be better to add a new field for the full name.

@arjunanan6
Copy link
Contributor Author

arjunanan6 commented Mar 22, 2023

@uranusjr That's also a solid option. But, would that not require changes to the log table to add in a new column referencing the full name?

@uranusjr
Copy link
Member

uranusjr commented Mar 22, 2023

Yes it does. Adding a column (with NULL default) is quite cheap, so the question is whether we want to do it. Speaking of that, why do we want the full name here in the first place? Maybe it is easier to change the UI to JOIN the user table instead?

@arjunanan6
Copy link
Contributor Author

@uranusjr There is a screenshot in my linked issue, the reason is to just make it clear in the Audit logs as to who has done what. At least in our case, it just references the azure ID which doesn't say anything.

Could you give me a hint on where to introduce the JOIN? I could take a look at it then.

@arjunanan6
Copy link
Contributor Author

@uranusjr Actually, figured out the addition of a new field to the log table, I was just overthinking it. I'll put some more into it and return :)

This is what it looks like:
image

@pierrejeambrun pierrejeambrun added the type:improvement Changelog: Improvements label Mar 22, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@arjunanan6
Copy link
Contributor Author

Hi @uranusjr, I've commited the suggested change. Is it good to go?

@uranusjr
Copy link
Member

uranusjr commented May 9, 2023

Doc building failure is unrelated.

@potiuk potiuk merged commit a03f6cc into apache:main May 17, 2023
@eladkal eladkal added the type:misc/internal Changelog: Misc changes that should appear in change log label Jun 8, 2023
eladkal added a commit that referenced this pull request Jun 8, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>

---------

Co-authored-by: Malthe Borch <mborch@gmail.com>
Co-authored-by: eladkal <45845474+eladkal@users.noreply.github.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
(cherry picked from commit a03f6cc)
@eladkal eladkal removed the type:improvement Changelog: Improvements label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit Log is unclear when using Azure AD login

7 participants