AIP-44 Migrate MetastoreBackend to Internal API #30331
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhenc
force-pushed
the
metastore_aip44
branch
2 times, most recently
from
97ad5fc to
d9ffefd
Compare
mhenc
requested review from
XD-DENG,
ashb,
bolkedebruin,
dstandish,
kaxil and
potiuk
as code owners
Contributor
Author
|
Made on top of #30282 so please review only the last commit. |
mhenc
force-pushed
the
metastore_aip44
branch
2 times, most recently
from
0d4727f to
9e53082
Compare
potiuk
approved these changes
Apr 18, 2023
Member
|
Needs conflict resolving :( |
mhenc
force-pushed
the
metastore_aip44
branch
3 times, most recently
from
bef0209 to
4ee0b3c
Compare
Contributor
Author
|
Thank you. Right, there were some significant merge conflicts. It should be fine now. |
Member
|
Hmmm. Tests failing? |
mhenc
force-pushed
the
metastore_aip44
branch
2 times, most recently
from
397201c to
fa6303f
Compare
Contributor
Author
|
Tests fixed |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate MetastoreBackend 's get_connections and get_variables to Internal API.
This change requires adding Connection to serializable types.
closes: #30242