Skip to content

Fix airflow module version check when using ExternalPythonOperator and debug logging level #30367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 7 commits into from
Jun 8, 2023
Merged

Fix airflow module version check when using ExternalPythonOperator and debug logging level #30367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ac5a313
set `_AIRFLOW__AS_LIBRARY="true"` for airflow version check
mathbou Mar 30, 2023
45e82da
Fix static check errors
uranusjr Mar 30, 2023
fce0663
more explicit comments about _AIRFLOW__AS_LIBRARY
mathbou Apr 13, 2023
097724a
Update airflow/operators/python.py
mathbou Apr 14, 2023
5c57d45
Update airflow/__init__.py
mathbou Jun 4, 2023
0e0bb6d
Fix code format
uranusjr Jun 8, 2023
9bc0b88
Update airflow/__init__.py
potiuk Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions airflow/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@

# Perform side-effects unless someone has explicitly opted out before import
# WARNING: DO NOT USE THIS UNLESS YOU REALLY KNOW WHAT YOU'RE DOING.
# This environment variable prevents proper initialization, and things like
# configs, logging, the ORM, etc. will be broken. It is only useful if you only
# access certain trivial constants and free functions (e.g. `__version__`).
if not os.environ.get("_AIRFLOW__AS_LIBRARY", None):
settings.initialize()

Expand Down
5 changes: 4 additions & 1 deletion airflow/operators/python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,10 @@ def _get_airflow_version_from_target_env(self) -> str | None:

try:
result = subprocess.check_output(
[self.python, "-c", "from airflow import __version__; print(__version__)"], text=True
[self.python, "-c", "from airflow import __version__; print(__version__)"],
text=True,
# Avoid Airflow logs polluting stdout.
env={**os.environ, "_AIRFLOW__AS_LIBRARY": "true"},
)
target_airflow_version = result.strip()
if target_airflow_version != airflow_version:
Expand Down