Skip to content

Conversation

@vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Mar 30, 2023

As agreed in #29579, remove the gauge scheduler.tasks.running
closes: #29578


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:Scheduler including HA (high availability) scheduler kind:documentation labels Mar 30, 2023
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eladkal
Copy link
Contributor

eladkal commented Apr 3, 2023

BTW I assume we need {pr_number}.significant.rst entry for this one?

@vincbeck
Copy link
Contributor Author

vincbeck commented Apr 4, 2023

BTW I assume we need {pr_number}.significant.rst entry for this one?

I just added it

@vincbeck
Copy link
Contributor Author

Anyone to review this one? :)

Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that we're removing this under the pretense of a bug-fix, given that it is broken currently? If that's the case that we don't need deprecation warnings, so it lgtm.

@potiuk potiuk merged commit cce9b22 into apache:main Apr 13, 2023
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Apr 14, 2023
wookiist pushed a commit to wookiist/airflow that referenced this pull request Apr 19, 2023
* Remove gauge scheduler.tasks.running

* Add significant.rst file

* Update newsfragments/30374.significant.rst

---------

Co-authored-by: Niko Oliveira <onikolas@amazon.com>
@vincbeck vincbeck deleted the vincbeck/scheduler_tasks_running branch May 19, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Scheduler including HA (high availability) scheduler kind:documentation type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scheduler.tasks.running metric is always 0

5 participants