Bump dependencies of google provider after ads removal #30403
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:google
potiuk
force-pushed
the
use-vendored-in-google-ads
branch
from
762a8fd to
7961795
Compare
Member
Author
|
cc: @lwyszomi BTW. vendoring-in google-ads immmediately frees a lot of other dependencies in our constraints Let's see if the tests pass., |
Member
Author
|
I might want to add some limits back to limit the risk (seems that some static checks are failing with the new versions, so we might want to limit them until #30067 is completed. |
Member
Author
|
Yep. Tests are failing so I will likely add the limits back. |
potiuk
force-pushed
the
use-vendored-in-google-ads
branch
from
7961795 to
fe19710
Compare
Member
Author
|
Actually - it's not that bad - just one test really faiked and rest was one search/replace missing I think. Let's see. |
potiuk
force-pushed
the
use-vendored-in-google-ads
branch
3 times, most recently
from
422ab33 to
46e2714
Compare
potiuk
changed the title
potiuk
force-pushed
the
use-vendored-in-google-ads
branch
from
46e2714 to
bbe84b6
Compare
We are temporarily switching to vendored-in google ads library in order to handle the clash of two issues: * Google ads switching off Google Ads v11 API * Google provider clinging on to old version of google-ads client due to protobuf <4 requirement from other google clients Strategic solution being worked out in apache#30067
potiuk
force-pushed
the
use-vendored-in-google-ads
branch
from
bbe84b6 to
648830d
Compare
Member
Author
|
Closing this one with preference of implementing the right changes as part of #30067 |
Contributor
yes, it will upgrade other SDK, because google-ads forced us to for example install protobuf<4. When you removed it from providers.yaml we don't have that restriction and SDK can be installed in latests version without conflicts. |
Member
Author
It's not even protobuf (yet). Those are other limits (I think limitation google ads put on For now. I've added those limits here: https://github.com/apache/airflow/blob/main/airflow/providers/google/provider.yaml#L80 So just a watchout you will have to remove those when you work on #30067 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are temporarily switching to vendored-in google ads library
in order to handle the clash of two issues:
due to protobuf <4 requirement from other google clients
Strategic solution being worked out in #30067
Based on #30399 (so only last commit counts)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.