-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add deferrable BatchOperator #30500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deferrable BatchOperator #30500
Conversation
ba40ff3 to
e3d8a79
Compare
|
Added label. Closed and reopened to rebuild for all python versions |
80be616 to
189e2c9
Compare
…airflow into batch_operator_async
|
There are multiple work in parallel to add deferrable operators in Amazon provider package. I do not think there is one better way than the other but I definitely think we should all follow the same pattern for consistency purposes. @syedahsn has been working on adding support for deferrable operators in Amazon provider package in #30032. For instance, he does not create a separate hook for all async operations which I agree with because, I think, having two hooks per service (one for sync operations, one for async operations) would be adding too many files and end up making the amazon provider package harder to maintain. As a result, I would try to follow the pattern initiated in #30032 while in the meantime we should also try to merge ASAP #30032 to avoid this kind of situation again. |
|
@vincbeck Thanks Vincent for the visibility on #30032. On our(Astronomer's) end too, we're building/donating quite a few deferrable operators across various providers and would like to also see if most people agree to the pattern, then we could use this pattern not only for Amazon providers but for other providers too. Just curious to know if there was a prior discussion somewhere regarding following this pattern. I see that we're still keeping the cc: @pankajastro @phanikumv @kaxil 👆🏽 Please take a look at the pattern of using a single class for the hook with deferrable param for its methods and would appreciate your thoughts on it. |
Not that I am aware of. I think the discussion actually happened in #30032 |
|
I just merged #30032 - so maybe that's a good time to align the approach @vincbeck @rajaths010494. Similar discussions happened befor when Astronomer was donating deferrable operators to Google Provider so maybe the learnings from those discussions and agreening on how to approahc Amazon provider coould be done here as well cc: @kaxil |
|
@pankajastro as discussed please check the approach mentioned here. |
@pankajkoti @syedahsn will appreciate your feedback on #30865 |
This PR donates the following BatchOperator deferrable developed in astronomer-providers repo to apache airflow.