Move Pydantic class serialization under AIP-44 feature flag #30560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pydantic representation of the ORM models is only used in AIP-44 in-progress feature, and we are moving to a new seialization implementation (more modular) in a near feature so in order to not unecessarily extend features in old serialization, but allow to test AIP-44, we are moving the use_pydantic_models parameter and it's implementation under _ENABLE_AIP_44 feature flag, so that it is not used accidentally. We will eventually remove it and add Pydantic serialization to the new serialization implementation.
potiuk
force-pushed
the
move-pydantic-serialization-under-aip-44-feature-flag
branch
from
e6f2909 to
46a1bc4
Compare
ephraimbuddy
approved these changes
Apr 10, 2023
potiuk
deleted the
move-pydantic-serialization-under-aip-44-feature-flag
branch
ephraimbuddy
added
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pydantic representation of the ORM models is only used in AIP-44 in-progress feature, and we are moving to a new seialization implementation (more modular) in a near feature so in order to not unecessarily extend features in old serialization, but allow to test AIP-44, we are moving the use_pydantic_models parameter and it's implementation under _ENABLE_AIP_44 feature flag, so that it is not used accidentally.
We will eventually remove it and add Pydantic serialization to the new serialization implementation.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.