-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix backfill KeyError when try_number out of sync #30653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
I believe a better solution is being discussed in #30669 - I think we really need to add a new db entity to handle all problems with try_num. Closing this as essentially duplicate - and I think discussions should happen there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hussein-awala @ashb @uranusjr -> maybe indeed (see the comment in #30669 (comment)) we could merge that one to 2.6.* to fix the backfill_job try_num calculation before we have a more permanent fix.
Need a second pair of eyes on that one.
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, LGTM
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Co-authored-by: Anthony Bush <anthony.bush@reddit.com> (cherry picked from commit 17d1f3a)
This patch ensures that backfills stop encountering KeyError when popping from running tasks.
TaskInstanceKey.reducedis no longer referenced and could be deprecated/removed.reduced_keyand instead usein-memory key.The issue goes back many years, but these stood out:
Note that scheduler_job_runner.py works around this issue too.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.