Updated app to support configuring the caching hash method for FIPS v2 #30675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchiapaikeo
requested review from
XD-DENG,
ashb,
bbovenzi,
kaxil and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:serialization
area:webserver
potiuk
approved these changes
Apr 17, 2023
Member
|
Nice, thanks for picking this one up! |
eladkal
reviewed
Apr 17, 2023
| caching_hash_method: | ||
| description: | | ||
| The caching algorithm used by the webserver. Must be a valid hashlib function name. | ||
| version_added: |
Contributor
There was a problem hiding this comment.
I guess we should put 2.7.0 here?
Member
There was a problem hiding this comment.
Unless @ephraimbuddy will decide to merge in to 2.6.0 ?
Member
There was a problem hiding this comment.
I know I wrote on slack that it is 2.7 - but on a hindsight - unless it's not too late - that one looks super safe
Member
There was a problem hiding this comment.
Ah. I see it is missing at all :(
Contributor
Author
There was a problem hiding this comment.
Ah whoops! Let me know if I can do a fast follow up here to add 2.7.0 here @potiuk
Contributor
There was a problem hiding this comment.
Let's tag it 2.6.0. I will no longer do the RC today
Member
There was a problem hiding this comment.
Yeah. Can you please add 2.6.0 added PR @vchiapaikeo :)?
wookiist
pushed a commit
to wookiist/airflow
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created in response to a stale PR at the direction of @eladkal: #28846
This was created to address issues that occurred in a FIPS enabled environment. This allows you to set the CACHING_HASH_METHOD config value to override the default of md5. Also updates the serialized_dag hash code to work even in a FIPS environment.
Testing:
Started up breeze and ensured webserver started fine:
Inspected serialized dag dag_hash field:
Modified the hash method to sha256 and restarted breeze with this configuration in
files/airflow-breeze-config/init.sh:Checked configuration:
Rechecked dag hash field:
Test a simple dag:
To explicit md5:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.