Add retry param in databrics async operator #30744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajastro
force-pushed
the
add_retry_databricks_async_op
branch
3 times, most recently
from
5d6ff51 to
7a8b92a
Compare
pankajastro
force-pushed
the
add_retry_databricks_async_op
branch
from
7a8b92a to
2ad5d17
Compare
Member
|
@alexott - WDYT? It looks good to me |
potiuk
approved these changes
Apr 22, 2023
alexott
suggested changes
Apr 23, 2023
Contributor
alexott
left a comment
alexott
left a comment
There was a problem hiding this comment.
let unify retry logic in sync & async versions.
Also, was it tested on the real Databricks instance?
Member
Author
yes, I have tested this. |
pankajastro
force-pushed
the
add_retry_databricks_async_op
branch
from
c05eebb to
1e4efa7
Compare
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, we do not set the tries parameter in Databricks
while initialising the hook from the trigger. This is problematic
if the Databricks API throw error in the trigger and the error is retriable.
In this case, currently, we have a retry limit and the delay is fixed.
This PR allows the user to modify the retry limit and the delay as required.
In addition, I'm also pushing the job id in xcom for
DatabricksSubmitRunDeferrableOperatorso that other tasks can use the existing job_id from xcom if require.
also, add logs while waiting for completion
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.