Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Apr 24, 2023

By having a github repository we allow to run CI tests for PRs outside of airflow repo. This is useful to test some changes to CI process. The github_repositry in testing command allows to push and use images in a fork of Airlfow.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Apr 24, 2023

Found out that it was missing during testing of #30839

By having a girhub repository we allow to run CI tests for PRs
outside of airflow repo. This is useful to test some changes to
CI process. The github_repositry in testing command allows to
push and use images in a fork of Airlfow.
@potiuk potiuk force-pushed the add-github-repository-to-testing-command branch from fcfcbe8 to 04ca1b2 Compare April 24, 2023 22:56
@potiuk potiuk merged commit 6e4de99 into apache:main Apr 25, 2023
@potiuk potiuk deleted the add-github-repository-to-testing-command branch April 25, 2023 07:23
potiuk added a commit to potiuk/airflow that referenced this pull request Apr 25, 2023
Following up after apache#30850 we also need to add github-repository option
to integration test in order to be able to test a PR in another
repository.
potiuk added a commit that referenced this pull request Apr 25, 2023
Following up after #30850 we also need to add github-repository option
to integration test in order to be able to test a PR in another
repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants