Add Deferrable Mode to RedshiftCreateClusterSnapshotOperator #30856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vincbeck
approved these changes
May 1, 2023
Contributor
There was a problem hiding this comment.
nit. Use @cached_property to create the hook?
Contributor
There was a problem hiding this comment.
in my opinion it's not useful to do this, because the run method is never executed more than once for a given object, so the cached_property thing is useless.
potiuk
approved these changes
May 6, 2023
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
I am ok with that one even without the @cached_property - but if you can change it that would be fine too. Seems to be common pattern Amazon provider.
Add async custom waiter support in get_waiter, and base_waiter.py Add Deferrable mode to RedshiftCreateClusterOperator Add RedshiftCreateClusterTrigger and unit test Add README.md for writing Triggers for AMPP
Add unit test to check for deferred exception
syedahsn
force-pushed
the
syedahsn/deferrable-redshift-create-cluster-snapshot
branch
from
9fef601 to
d455d65
Compare
…edshift-create-cluster-snapshot
…edshift-create-cluster-snapshot
vandonr-amz
deleted the
syedahsn/deferrable-redshift-create-cluster-snapshot
branch
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add deferrable mode to
RedshiftCreateClusterSnapshotOperatorusing aiobotocore waiters, following the method described in README.md.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.