Executor events are not always "exited" here #30859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
dstandish
force-pushed
the
sometimes-handle-not-exit
branch
from
4a157f5 to
ab21f80
Compare
uranusjr
reviewed
May 8, 2023
jedcunningham
approved these changes
May 9, 2023
uranusjr
approved these changes
May 10, 2023
eladkal
added
the
type:misc/internal
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
(cherry picked from commit f39ccad)
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wolfier this makes more general that misleading message we encountered the other day. (task isn't always "exiting")
what do you think of the current messaging?