Save DAG parsing time if dag is not scheduleable #30911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutomationDev85
changed the title
potiuk
reviewed
Apr 29, 2023
potiuk
reviewed
May 6, 2023
AutomationDev85
force-pushed
the
feature/optimize-scheduler-run-time-5
branch
from
747a0bb to
ec38a14
Compare
uranusjr
reviewed
Jun 13, 2023
uranusjr
reviewed
Jul 6, 2023
uranusjr
approved these changes
Jul 6, 2023
Member
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
Just one suggestion to clarify a comment. Logic looks good to me.
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
potiuk
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi airflow community,
this is my fifth PR and be happy to work DAG parsing runtime. We faced an issue with slow dag parsing if DAG has huge amount of dagruns and DB query is slow down the run time during DAG parsing. Then the DAG parsing was skipped due to long running query and this is not required if DAG is not scheduled. I think DAGs which are not scheduled have biggest change to have huge number dagruns and this save runtime during this use case.
This PR will check is the DAG is not scheduled and then skips the DB query which are not required to be executed.