Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Apr 29, 2023


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk requested a review from ashb as a code owner April 29, 2023 14:56
@boring-cyborg boring-cyborg bot added area:production-image Production image improvements and fixes kind:documentation labels Apr 29, 2023
@potiuk
Copy link
Member Author

potiuk commented Apr 29, 2023

We already have a few PRs that have wrongly generated version (#30827 for example) so likely it's a good time to merge 2.6.0.dev0 -> 2.7.0.dev0 :)

@potiuk
Copy link
Member Author

potiuk commented Apr 29, 2023

Not sure which part of the release process it is in, but it looks like it shoudl be done slightly earlier (i.e. when we cut-off the 2.6.0 branch).

# Example: dataset_manager_kwargs = {{"some_param": "some_value"}}
# dataset_manager_kwargs =

# (experimental) Whether components should use Airflow Internal API for DB connectivity.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have this change, this seems unrelated ?

Copy link
Member Author

@potiuk potiuk Apr 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite the contrary. They are very much related. They were (correctly) automatically added by pre-commit.

Those parameters have version-added = 2.7.0. This was implemented as part of the feature flags for AIP-44 and AIP-52, but in order to not comploicate it further we restricted automated moving parameters from .yaml to config based on "version-added" > currrent version. We moved the related parameters that were scheduled for 2.7 to have "version-added=2.7.0" so they started to appear only when we moved the version to 2.7.0.

@jedcunningham jedcunningham merged commit 21ee151 into apache:main Apr 30, 2023
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label May 8, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.7.0 milestone May 8, 2023
@potiuk potiuk deleted the update-dev-version-to-2-7-0 branch June 4, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:production-image Production image improvements and fixes changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants