-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Use AirflowProviderDeprecationWarning in providers
#30975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pankajastro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it makes sense to add a pre-commit to enforce contributor to use AirflowProviderDeprecationWarning and not DeprecationWarning in providers I feel that it would be really nice if we know in which version the deprecation is added?
See #30996 As for the 2nd question. We have that if we want to use it Lines 386 to 390 in bef892e
|
Now that Providers minimum Airflow version is 2.4.0 we can replace `DeprecationWarning` with `AirflowProviderDeprecationWarning`
uranusjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some more but GitHub doesn’t allow me to add them. Those are trivial anyway and don’t strictly need to be added here.
Now that Providers minimum Airflow version is 2.4.0 we can replace
DeprecationWarningwithAirflowProviderDeprecationWarning^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.