Chart: add custom volumemounts to dag processor waitForMigrations init container #30990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aakcht
force-pushed
the
dagProcessor_migrations_volumemounts
branch
from
1cf9c51 to
f99d5db
Compare
Aakcht
force-pushed
the
dagProcessor_migrations_volumemounts
branch
from
f99d5db to
096feab
Compare
potiuk
approved these changes
May 6, 2023
15 tasks
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason global volumemounts are missing from dag processor waitForMigrations init container (while all other waitForMigrations init containers have it) . This PR fixes it. Also I decided to add
dagProcessor.extraVolumeMountsto dag processor waitForMigrations init container, since this is common behavior for all other waitForMigrations init containers.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.