Add options to KubernetesPodOperator #30992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
provider:cncf-kubernetes
RachitSharma2001
force-pushed
the
kub-pod-run-options
branch
from
6eeae2e to
1d18d28
Compare
Contributor
Author
|
Sorry about that, the tests were failing before, but now they all pass. |
o-nikolas
reviewed
May 4, 2023
| security_context: dict | None = None, | ||
| container_security_context: dict | None = None, | ||
| dnspolicy: str | None = None, | ||
| dns_config: dict | None = None, |
Contributor
There was a problem hiding this comment.
Kube has a type for this right?
Suggested change
| dns_config: dict | None = None, | |
| dns_config: V1PodDNSConfig | None = None, |
Contributor
Author
There was a problem hiding this comment.
Good catch, I have pushed changes to reflect this.
| ) | ||
|
|
||
| @patch(HOOK_CLASS, new=MagicMock) | ||
| def test_pod_additional_options(self): |
Contributor
There was a problem hiding this comment.
Nit: something about this test name seems too generic, maybe:
Suggested change
| def test_pod_additional_options(self): | |
| def test_pod_dns_options(self): |
pankajkoti
reviewed
May 7, 2023
Comment on lines
+285
to
+287
| dns_config: k8s.V1PodDNSConfig | None = None, | ||
| hostname: str | None = None, | ||
| subdomain: str | None = None, |
Member
There was a problem hiding this comment.
Can you please add these parameters to the docstring above?
Contributor
Author
There was a problem hiding this comment.
Good catch, I had forgotten to add them. I have added them now.
Contributor
Author
|
Hi everyone, I was wondering if there was anything else I should add to this PR or if these changes look good? |
o-nikolas
approved these changes
May 9, 2023
potiuk
approved these changes
May 10, 2023
potiuk
approved these changes
May 10, 2023
80 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #30851
I have added the following options to the kubernetes pod operator:
--dns,--dns-searches, and--dns-optarguments for docker run--hostnameargument for docker run