Some minor updates to the Airflow release Doc #31024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
requested review from
ashb,
jedcunningham,
kaxil and
potiuk
as code owners
ephraimbuddy
force-pushed
the
update-releasedoc
branch
2 times, most recently
from
fb5fb14 to
29ad965
Compare
| check=True, | ||
| ) | ||
| console_print("Files pushed to svn") | ||
| os.chdir(repo_root) |
Member
There was a problem hiding this comment.
I don't think you should need this change. remove_old_releases moves to a different dir anyways, then moves back to the repo root.
Contributor
Author
There was a problem hiding this comment.
At that point, we are in the "versions" directory. We can't change to "asf-dist..." right there because it cannot be found.
Member
There was a problem hiding this comment.
I see. Can we the change remove_old_releases to do this "reset to repo root" instead?
| check=True, | ||
| ) | ||
| console_print("Files pushed to svn") | ||
| os.chdir(repo_root) |
Member
There was a problem hiding this comment.
I see. Can we the change remove_old_releases to do this "reset to repo root" instead?
ephraimbuddy
force-pushed
the
update-releasedoc
branch
from
bfb5e5c to
898c9b2
Compare
potiuk
approved these changes
May 16, 2023
jedcunningham
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to what I noticed during the 2.6.0 release