Add deferrable mode to GCSUploadSessionCompleteSensor
#31081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
1 task
pankajkoti
reviewed
May 7, 2023
pankajkoti
approved these changes
May 14, 2023
ashb
reviewed
May 15, 2023
sunank200
reviewed
May 15, 2023
Collaborator
sunank200
left a comment
sunank200
left a comment
There was a problem hiding this comment.
I think we should add doc changes and example DAGs as well as part of this PR
phanikumv
force-pushed
the
gcs_upload
branch
2 times, most recently
from
8681b0a to
ad3f3f2
Compare
pankajkoti
approved these changes
May 19, 2023
Member
pankajkoti
left a comment
pankajkoti
left a comment
There was a problem hiding this comment.
Looks good to me, minor suggestions inline if you'd like to consider.
ephraimbuddy
approved these changes
May 25, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR donates the GCSUploadSessionCompleteSensorAsync from astronomer-providers to Airflow
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.