Skip to content

Conversation

@pankajastro
Copy link
Member

@pankajastro pankajastro commented May 5, 2023

Look like we miss to update the version in API spec in #30966
so it shows 2.5.3 in https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html.
maybe we should consider adding a target in breeze to update the version in all required files?


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@pankajastro pankajastro requested a review from ephraimbuddy as a code owner May 5, 2023 11:30
@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label May 5, 2023
Look like we miss to update the version in API spec in PR apache#30966
so it showing 2.5.3 in https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html.
maybe we should consider adding a target in breeze to update the version in all required files?
@potiuk
Copy link
Member

potiuk commented May 5, 2023

I think we should also add it to dev/release process if missing there @ephraimbuddy ?

@potiuk potiuk added this to the Airflow 2.6.1 milestone May 5, 2023
@potiuk
Copy link
Member

potiuk commented May 5, 2023

And I think we should make it 2.6.1 really @pankajastro (sorry @pankajkoti bad completion).

@ephraimbuddy
Copy link
Contributor

We haven't released 2.6.0 Yet. I think it's still Ok until 2.6.0 is released

@ephraimbuddy
Copy link
Contributor

We haven't released 2.6.0 Yet. I think it's still Ok until 2.6.0 is released

Oh, got what you mean!

@potiuk
Copy link
Member

potiuk commented May 5, 2023

Hmmm. Not sure. I think (can't remember that but we can look it up - API spec was always in sync with Airflow version but the client version could be dfferent - because we could have 2.6.0 of python client and 2.6.1 of go client released at the same time. I think. Patchlevel versions of the clients could be different, but the api spec was supposed to be in-sync with the airflow version.

and yes, it's confusing, but I think we have no other way :)

@pankajastro
Copy link
Member Author

And I think we should make it 2.6.1 really @pankajastro

actually, it is confusing to me, when we are on the main branch it should point to some 2.7.0.dev0 version at release time we should update to 2.6.1 etc then again bump to dev??

@pankajastro
Copy link
Member Author

API spec was always in sync with Airflow version

I think so by looking past PR where we have updated API specs in past.

@potiuk
Copy link
Member

potiuk commented May 5, 2023

actually, it is confusing to me, when we are on the main branch it should point to some 2.7.0.dev0 version at release time we should update to 2.6.1 etc then again bump to dev??

No - in stable branch we do not use dev at all. We only use dev in main

@potiuk
Copy link
Member

potiuk commented May 5, 2023

But yeah - you are right @pankajastro - those should be two separate changes:

  1. to main -> 2.7.0.dev0
  2. in stable -> 2.6.1

:D

@potiuk
Copy link
Member

potiuk commented May 5, 2023

The easiest I think will be that we merge 2.7.0.dev0 here and @ephraimbuddy when cherry-picking will change it to 2.6.1 manually :)

@pankajastro
Copy link
Member Author

The easiest I think will be that we merge 2.7.0.dev0 here and @ephraimbuddy when cherry-picking will change it to 2.6.1 manually :)

Yes, this makes sense to me.

@ashb ashb modified the milestones: Airflow 2.6.1, Airflow 2.7.0 May 6, 2023
@potiuk potiuk merged commit f36587b into apache:main May 8, 2023
@potiuk potiuk modified the milestones: Airflow 2.7.0, Airflow 2.6.1 May 8, 2023
@potiuk
Copy link
Member

potiuk commented May 8, 2023

cc: @ephraimbuddy - also this one should be sort-of cherry-picked to 2.6.1 :) (i.e. with 2.6.1 instead of 2.7.0.dev0)

@potiuk
Copy link
Member

potiuk commented May 8, 2023

(already is I see :)

@ephraimbuddy ephraimbuddy deleted the update_version branch May 9, 2023 07:55
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants