-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Update version in API spec #31086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version in API spec #31086
Conversation
Look like we miss to update the version in API spec in PR apache#30966 so it showing 2.5.3 in https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html. maybe we should consider adding a target in breeze to update the version in all required files?
7a2be1d to
ef6b1ee
Compare
|
I think we should also add it to dev/release process if missing there @ephraimbuddy ? |
|
And I think we should make it 2.6.1 really @pankajastro (sorry @pankajkoti bad completion). |
|
We haven't released 2.6.0 Yet. I think it's still Ok until 2.6.0 is released |
Oh, got what you mean! |
|
Hmmm. Not sure. I think (can't remember that but we can look it up - API spec was always in sync with Airflow version but the client version could be dfferent - because we could have 2.6.0 of python client and 2.6.1 of go client released at the same time. I think. Patchlevel versions of the clients could be different, but the api spec was supposed to be in-sync with the airflow version. and yes, it's confusing, but I think we have no other way :) |
actually, it is confusing to me, when we are on the main branch it should point to some 2.7.0.dev0 version at release time we should update to 2.6.1 etc then again bump to dev?? |
I think so by looking past PR where we have updated API specs in past. |
No - in stable branch we do not use dev at all. We only use dev in main |
|
But yeah - you are right @pankajastro - those should be two separate changes:
:D |
|
The easiest I think will be that we merge 2.7.0.dev0 here and @ephraimbuddy when cherry-picking will change it to 2.6.1 manually :) |
Yes, this makes sense to me. |
|
cc: @ephraimbuddy - also this one should be sort-of cherry-picked to 2.6.1 :) (i.e. with 2.6.1 instead of 2.7.0.dev0) |
|
(already is I see :) |
Look like we miss to update the version in API spec in #30966
so it shows 2.5.3 in https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html.
maybe we should consider adding a target in breeze to update the version in all required files?
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.