Skip to content

Conversation

@ying-w
Copy link
Contributor

@ying-w ying-w commented May 7, 2023

  • Point out lack of logging on callback functions (errors are silent)
  • Add more info about context

closes

Flag lack of logging on callback functions
@ying-w
Copy link
Contributor Author

ying-w commented May 7, 2023

@potiuk i'm not sure how to check the rendering of RST

Also, do you have tips on what needs to be changed in config to show scheduler logs? I'm not sure this is the right term and it wasn't obvious from reading logging-tasks

@ying-w ying-w marked this pull request as ready for review May 7, 2023 03:50
@ying-w ying-w requested a review from potiuk as a code owner May 7, 2023 03:50
@ying-w ying-w changed the title Update callbacks.rst Update callbacks documentation (errors and context) May 7, 2023
As such, task changes set by the command line interface (:doc:`CLI <../../howto/usage-cli>`) or user interface (:doc:`UI <../../ui>`) do not
execute callback functions.

.. warning::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this level be a warning or note?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i put it as warning because it wasn't obvious that there wouldn't be any errors shown in ui when callback function is broken (like function calls were incorrect syntax)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning is fine. There are some static checks/docs build errors to fix though (see the failed checks).

@ying-w
Copy link
Contributor Author

ying-w commented May 7, 2023

There was a timeout waiting for docker image, can someone re-trigger the github action? it seems like there is quite the queue right now

@potiuk
Copy link
Member

potiuk commented May 7, 2023

There was a timeout waiting for docker image, can someone re-trigger the github action? it seems like there is quite the queue right now

The queue was rather small. But It looks like there was some kind of event that happens once every few months that we have not diagnosed yet (and given that we we are likely to move to k8s infrastructure in a near future it makes little sense to spend time on) - resulting with our auto-scaling group goes down 0 and get stuck.

I pushed it a little to unstuck it (it usually helps) and restarting the job now.

@ying-w
Copy link
Contributor Author

ying-w commented May 8, 2023

@potiuk a timeout occurred in gh actions when trying to get docker image, do you want to rerun or just merge?

@potiuk
Copy link
Member

potiuk commented May 8, 2023

That's a quck test when re-run. (passed).

@potiuk potiuk merged commit a2a9867 into apache:main May 8, 2023
@ying-w ying-w deleted the patch-1 branch May 8, 2023 20:01
@eladkal eladkal added this to the Airflow 2.6.2 milestone May 9, 2023
@eladkal eladkal added the type:doc-only Changelog: Doc Only label May 9, 2023
eladkal pushed a commit that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants