-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Update callbacks documentation (errors and context) #31116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Flag lack of logging on callback functions
add context links
|
@potiuk i'm not sure how to check the rendering of RST Also, do you have tips on what needs to be changed in config to show scheduler logs? I'm not sure this is the right term and it wasn't obvious from reading logging-tasks |
| As such, task changes set by the command line interface (:doc:`CLI <../../howto/usage-cli>`) or user interface (:doc:`UI <../../ui>`) do not | ||
| execute callback functions. | ||
|
|
||
| .. warning:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this level be a warning or note?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i put it as warning because it wasn't obvious that there wouldn't be any errors shown in ui when callback function is broken (like function calls were incorrect syntax)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning is fine. There are some static checks/docs build errors to fix though (see the failed checks).
|
There was a timeout waiting for docker image, can someone re-trigger the github action? it seems like there is quite the queue right now |
The queue was rather small. But It looks like there was some kind of event that happens once every few months that we have not diagnosed yet (and given that we we are likely to move to k8s infrastructure in a near future it makes little sense to spend time on) - resulting with our auto-scaling group goes down 0 and get stuck. I pushed it a little to unstuck it (it usually helps) and restarting the job now. |
|
@potiuk a timeout occurred in gh actions when trying to get docker image, do you want to rerun or just merge? |
|
That's a quck test when re-run. (passed). |
(cherry picked from commit a2a9867)
closes