CreateBatchPredictionJobOperator Add batch_size param for Vertex AI BatchPredictionJob objects
#31118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
VVildVVolf
changed the title
pankajkoti
approved these changes
May 7, 2023
potiuk
approved these changes
May 7, 2023
airflow/providers/google/cloud/operators/vertex_ai/batch_prediction_job.py
Show resolved
Hide resolved
VVildVVolf
changed the title
CreateBatchPredictionJobOperator Add batch_size param for Vertex AI BatchPredictionJob objects
potiuk
reviewed
May 9, 2023
airflow/providers/google/cloud/hooks/vertex_ai/batch_prediction_job.py
Outdated
Show resolved
Hide resolved
potiuk
approved these changes
May 9, 2023
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Fine - with the NIT for description.
…n_job.py Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
hussein-awala
approved these changes
May 9, 2023
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
It looks good after the last change
potiuk
approved these changes
May 9, 2023
Contributor
Author
|
@potiuk, @hussein-awala, Is there anything else can be improved before merging? :) |
Member
|
Nope. Merged :). |
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add batch_size param for Vertex AI BatchPredictionJob objects.
Vertex AI python sdk has BatchPredictionJob.create method, introduced with the 1.13.1 version. So the PR updates with passing
batch_sizeparam:CreateBatchPredictionJobOperatorBatchPredictionJobHookWhen the
batch_sizeis introduced in 1.13,create_request_timeouthad already been there, so this param is also added to avoid any confuse.The change itself is pretty simple.