Add conditional output processing in SQL operators #31136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
potiuk
force-pushed
the
add-output-processing-when-output-file-used
branch
from
7246455 to
e7223d0
Compare
uranusjr
reviewed
May 8, 2023
The change adds conditional processing of output based on criteria that can be overridden by the operator extending the common.sql BaseSQLOperator. Originally, output processing has only been happening if "do_xcom_push" was enabled, but in some cases we want to run processing also when do_xcom_push is disabled (for example in case of databricks SQL operator, it might be done when the output is redirected to a file). This change enables it. Fixes: apache#31080
potiuk
force-pushed
the
add-output-processing-when-output-file-used
branch
from
e7223d0 to
e6c6d68
Compare
Member
Author
|
Fixed. |
uranusjr
approved these changes
May 9, 2023
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change adds conditional processing of output based on criteria that can be overridden by the operator extending the common.sql BaseSQLOperator. Originally, output processing has only been happening if "do_xcom_push" was enabled, but in some cases we want to run processing also when do_xcom_push is disabled (for example in case of databricks SQL operator, it might be done when the output is redirected to a file).
This change enables it.
Fixes: #31080
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.