Skip to content

Conversation

@VVildVVolf
Copy link
Contributor

Refactoring names of dataflow operator's unit tests.

To make the code more clear, some unit tests are updated according to Airflow 2 naming of operators.


@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels May 9, 2023
@VVildVVolf VVildVVolf marked this pull request as ready for review May 9, 2023 16:54
@VVildVVolf
Copy link
Contributor Author

VVildVVolf commented May 13, 2023

@potiuk , sorry for requesting with minor change, just not sure the appropriate way to find write-access reviewers.

The change is separated from the main fix, to make that change more focused and obvious. Please let me know if this kind of refactoring is not needed or should be included to a solution of a problem.

@pierrejeambrun
Copy link
Member

pierrejeambrun commented May 18, 2023

@VVildVVolf We get notifications on every new comment/commit on a PR, so there is usually no need to ping specific people.

Waiting a couple of weeks is perfectly fine for low priority change.

@potiuk potiuk merged commit d2cf8a5 into apache:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants