Fix deprecated import in Oracle example #31166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The reason why it has not failed in #30979 is because optimisations we have - we do not run all import tests in "single provider" change only I will think how to avoid that - should be possible. |
hussein-awala
approved these changes
May 9, 2023
Member
Author
|
Almost :) |
The apache#30979 added examples for Oracle, but the examples used deprecated imports to OracleOperator (and it has not been caught as provider tests did not run on changing just examples). This PR changes the import to non-deprecated SQLExecuteQueryOperator
potiuk
force-pushed
the
fix-warning-in-oracle-example
branch
from
2b85ce4 to
624d264
Compare
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #30979 added examples for Oracle, but the examples used deprecated imports to OracleOperator (and it has not been caught as provider tests did not run on changing just examples).
This PR changes the import to non-deprecated SQLExecuteQueryOperator
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.