Skip to content

Conversation

@utkarsharma2
Copy link
Contributor

@utkarsharma2 utkarsharma2 commented May 11, 2023

Added notifier for pagerduty.

Example usage -

BashOperator(
            task_id="mytask",
            bash_command="redis-cli ping",
            on_failure_callback=[
                send_pagerduty_notification(
                    summary="The task {{ ti.task_id }} failed",
                    severity="critical",
                    source="airflow dag_id: {{dag.dag_id}}",
                    dedup_key="{{dag.dag_id}}-{{ti.task_id}}",
                    group="{{dag.dag_id}}",
                    component="airflow",
                    class_type="Prod Data Pipeline",
                )
            ],
        )

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to add entry in provider.yaml (see #29191 )
the entry is needed so the new notifier will be listed in the core-extensions section

@utkarsharma2
Copy link
Contributor Author

utkarsharma2 commented May 12, 2023

@eladkal Added the changes in provider.yml

@eladkal eladkal mentioned this pull request May 13, 2023
utkarsharma2 and others added 7 commits May 15, 2023 09:24
…y_notifier_howto_guide.rst

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
…y_notifier_howto_guide.rst

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
utkarsharma2 and others added 2 commits May 18, 2023 07:50
…y_notifier_howto_guide.rst

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
@jedcunningham jedcunningham requested a review from eladkal May 22, 2023 22:12
Copy link
Contributor

@ephraimbuddy ephraimbuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eladkal can you take a look again?

@ephraimbuddy ephraimbuddy dismissed eladkal’s stale review June 8, 2023 07:11

Requested changes have been addressed

@ephraimbuddy ephraimbuddy merged commit 8d78f90 into apache:main Jun 8, 2023
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!
LGTM!

Thank you @utkarsharma2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants