Skip to content

Conversation

@utkarsharma2
Copy link
Contributor

Add missing change event API support for pagerduty.

API ref - https://developer.pagerduty.com/docs/ZG9jOjExMDI5NTgy-send-a-change-event

@eladkal
Copy link
Contributor

eladkal commented May 12, 2023

Not blocking but preferably lets switch to official SDK: #31251
That way the hook will have any endpoint needed without adding each one manually

@utkarsharma2
Copy link
Contributor Author

utkarsharma2 commented May 12, 2023

@eladkal Sure, I'll take care of this. Could you please assign the ticket to me?

@utkarsharma2
Copy link
Contributor Author

@eladkal I think we already are using pdpyras, maybe we can use specific methods offered by the SDK instead of generic post() WDYT?

I have used send_change_event instead of post in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants