Add send_event method in PagerdutyEventsHook #31290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@eladkal Please review. |
send_event() methods is suppose to replace PagerdutyEventsHook's create_event() method. Within send_event() we are using PagerdutySDK's send_event() instead of post() which is specific to our requirment. Also added deprecation warning in send_event() method
utkarsharma2
force-pushed
the
UsePagerdutySDK
branch
from
ff1bb81 to
d6d1a73
Compare
jedcunningham
approved these changes
May 22, 2023
1 task
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send_event() uses pdpyras's send_event() method which is more specific to our cases of sending events to pagerduty than generic pdpyras's post() call.
Since the response of the pdpyras's send_event() is only the
dedup_keyand not the entire response object, which breaks the interface. Add a new method to host the call to pdpyras's send_event() and add a deprecation warning for thecreate_event()which calls pdpyras's generic post().related: #31251