Always pass named type_ arg to drop_constraint #31306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems Alembic recently starts to enforce this argument being passed using a keyword (instead of positional). These are failing since the upstream change.
eladkal
approved these changes
May 16, 2023
dstandish
approved these changes
May 16, 2023
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 16, 2023
The new alembic (1.11.0) requires parameters to be keyword parameters in methods used in migrations. Part of the problem has been fixed in apache#31306 and apache#31302 but still some migrations that are specifically run in case of mssql need to use migration parameters.
2 tasks
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems Alembic recently starts to enforce this argument being passed using a keyword (instead of positional). These are failing since the upstream change.