Skip to content

Conversation

@ying-w
Copy link
Contributor

@ying-w ying-w commented May 17, 2023

closes: #31337

When things to assigned to blob will show up in blob._changes

A subset of these fields will be assigned to object_metadata which is used when uploading

https://github.com/googleapis/python-storage/blob/a436e3ae481187faa6796cdcd6eca1a6f17e150f/google/cloud/storage/blob.py#L1676

This change adds a parameter that will be passed to cacheControl

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels May 17, 2023
@ying-w
Copy link
Contributor Author

ying-w commented May 19, 2023

@eladkal can you review

@pankajkoti pankajkoti requested a review from eladkal May 19, 2023 17:31
@ying-w
Copy link
Contributor Author

ying-w commented May 23, 2023

@potiuk can you review?

@potiuk potiuk merged commit 2336630 into apache:main Jun 8, 2023
@ying-w ying-w deleted the gcs_cachecontrol branch June 12, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCSHook support for cacheControl

3 participants