Fix error handling when pre-importing modules in DAGs #31401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
We shouldn't raise an exception if the file we are trying to pre-import modules from has a nullbyte. It's likely not even a python DAG.
jedcunningham
force-pushed
the
fix_bad_zip_import
branch
from
6b4a925 to
d58ad36
Compare
potiuk
approved these changes
May 18, 2023
potiuk
reviewed
May 18, 2023
jedcunningham
commented
May 18, 2023
danielvdende
added a commit
to godatadriven/whirl
that referenced
this pull request
May 26, 2023
A problem was introduced in Airflow 2.6.0. Due to [PR30495](apache/airflow#30495) in Airflow, if any binary files happen to be in the `dags` folder, the dag processor manager will constantly crash, resulting in no DAGs being properly parsed. It's caused by some over-eager parsing of all files, regardless of type. The working fix is to ensure that these binary files are in the .airflowignore file, as mentioned [here](apache/airflow#31519). A different fix was supposed to land in 2.6.1, but having tested this, it does not seem to work (yet). (apache/airflow#31401)
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
(cherry picked from commit 24a94bb)
eladkal
pushed a commit
that referenced
this pull request
Jun 9, 2023
(cherry picked from commit 24a94bb)
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't raise an exception if the file we are trying to pre-import
modules from has a nullbyte. It's likely not even a python DAG.
Related: #30495, #31061