Skip to content

Conversation

@vincbeck
Copy link
Contributor

This PR is a follow up of #31135. It had been decided to split #31135 in multiple PRs to make it easier to review. This PR scope is the providers only. However, some of the providers are not included in this PR to make it easier to review it. These other providers have their own dedicated PR:


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

vincbeck and others added 2 commits May 23, 2023 11:17
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@vincbeck
Copy link
Contributor Author

Tests are failing because of: This PR did not have "allow suspended provider changes" label set so it will fail.. Can a committer set this label please? It makes sense to apply modifications for suspended providers as well. Otherwise, once the D400 check enabled, main will fail

@potiuk potiuk added the allow suspended provider changes Allow changes in suspended providers label May 23, 2023
@potiuk potiuk closed this May 23, 2023
@potiuk potiuk reopened this May 23, 2023
@potiuk
Copy link
Member

potiuk commented May 23, 2023

Label set. Closed/reopened to rebuild.

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of minor ones!

@vincbeck
Copy link
Contributor Author

vincbeck commented Jun 1, 2023

All green and approved :) Feel free to merge :)

@uranusjr uranusjr merged commit a59076e into apache:main Jun 2, 2023
@vincbeck vincbeck deleted the vincbeck/d400-providers branch June 5, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants