-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Cascade update of taskinstance to TaskMap table #31445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ce58b8d to
db35322
Compare
|
Would this be performant if the tables contain a lot of rows? I seem to recall creating a new index has performance issues. |
Updating a taskinstance's map_index etc should cascade to the task_map table else we would get foreign key violation error when updating a task instance from unmapped to mapped.
db35322 to
12348af
Compare
Do you mean a performance issue when upgrading? Like taking a lot of time to run the upgrade? I don't think there would be a performance issue but it's worth testing |
|
Yes when upgrading. |
jedcunningham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(assuming no catastrophic performance issues are found)
|
I have tested the upgrade and downgrade with 17million rows in taskinstance and dagrun tables, 15million rows in task_map table. So a total of 1.26s for upgrade and 0.78s for downgrade |
(cherry picked from commit f6bb474)

Updating a taskinstance's map_index etc should cascade to the task_map table
else we would get foreign key violation error when updating a task instance from unmapped
to mapped.
closes: #31431