Use kube_client over default CoreV1Api for deleting pods #31477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:CLI
provider:cncf-kubernetes
hussein-awala
approved these changes
May 24, 2023
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
It looks good, and I see that we already use get_kube_client to list the pods.
You just need to fix the static checks, please follow these steps to activate pre-commit hooks in order to fix the CI of this PR and avoid the future similar problems.
Contributor
Author
|
Thank you! I did run the checks but the failure seemed unrelated to my PR as other open PRs had the same failure - see also #31500. Let me know if I've missed anything. |
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
(cherry picked from commit adf0cae)
eladkal
pushed a commit
that referenced
this pull request
Jun 9, 2023
(cherry picked from commit adf0cae)
62 tasks
|
Thank you for this, Sir. I thought I was mad for patching it myself locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the helper util Kubernetes client over the default CoreV1Api client when deleting pods through the CLI. In the original implementation PR this change was agreed upon but never made: https://github.com/apache/airflow/pull/11802/files#r607034452
Closes #31476
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.