Skip to content

Conversation

@hussein-awala
Copy link
Member

closes: #31573

In hvac 0.7.0, all auth method classes were moved under the auth property on the hvac.Client class, and the old methods were deprecated and removed in the version 1.0.0.
In this PR I switch to the new methods for the last two authentication methods which are on the old ones: userpass and aws_iam.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What min version of hvac do we depend on? Do we need to bump that version, or is the min requirement already high enough?

I'm approving on the grounds that you've checked this and we're good with the min already.

@hussein-awala
Copy link
Member Author

What min version of hvac do we depend on? Do we need to bump that version, or is the min requirement already high enough?
I'm approving on the grounds that you've checked this and we're good with the min already.

@ashb yes I already checked it, the min version of hvac is 0.10 which is high enough for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vault AWS Login not working

3 participants