-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add possibility to disable logging the pod template in a case when task fails #31595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to disable logging the pod template in a case when task fails #31595
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for this new feature?
I've added a simple test, pls review if it's ok |
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
…s://github.com/svdimchenko/airflow into feat/configurable-log-pod-on-failure-parameter
|
Hey @hussein-awala @jedcunningham could you advice if smth additional is expected to merge this PR ? |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Add possibility to disable logging the pod template in a case when task fails.
The problem is that when the task fails, the log tail is full with pod template and it's really hard to read app's logs which was run inside the pod. The current PR adds possibility to enable | disable pod template logging when the task fails.