Skip to content

Conversation

@svdimchenko
Copy link
Contributor

Add possibility to disable logging the pod template in a case when task fails.

The problem is that when the task fails, the log tail is full with pod template and it's really hard to read app's logs which was run inside the pod. The current PR adds possibility to enable | disable pod template logging when the task fails.

@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes (k8s) provider related issues area:providers labels May 29, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented May 29, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@pankajkoti pankajkoti requested a review from hussein-awala May 29, 2023 13:43
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this new feature?

@svdimchenko
Copy link
Contributor Author

Can you add a test for this new feature?

I've added a simple test, pls review if it's ok

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hussein-awala hussein-awala added the type:new-feature Changelog: New Features label May 30, 2023
@svdimchenko svdimchenko requested a review from jedcunningham May 31, 2023 10:36
@svdimchenko
Copy link
Contributor Author

Hey @hussein-awala @jedcunningham could you advice if smth additional is expected to merge this PR ?

@hussein-awala hussein-awala merged commit d8086a3 into apache:main Jun 5, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 5, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@svdimchenko svdimchenko deleted the feat/configurable-log-pod-on-failure-parameter branch June 16, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues type:new-feature Changelog: New Features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants