Fix overriding default_args in nested task groups
#31608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hussein Awala <hussein@awala.fr>
Signed-off-by: Hussein Awala <hussein@awala.fr>
ashb
reviewed
May 30, 2023
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
uranusjr
changed the title
default_agrs in nested task groupsdefault_args in nested task groups
uranusjr
approved these changes
May 30, 2023
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
* add unit tests for default_args overriding in task group Signed-off-by: Hussein Awala <hussein@awala.fr> * fix overriding default args in nested task groups Signed-off-by: Hussein Awala <hussein@awala.fr> * Update airflow/utils/task_group.py Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> --------- Signed-off-by: Hussein Awala <hussein@awala.fr> Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> (cherry picked from commit 9e8627f)
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #31604
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.