Decrease trigger ending log message level to info #31802
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
Member
|
I think @dstandish should have a say on this one. |
potiuk
approved these changes
Jun 8, 2023
Member
Author
Indeed, I was going to mention him. |
dstandish
requested changes
Jun 9, 2023
Contributor
There was a problem hiding this comment.
nope can't do this.
this is a special log message that signals to the wrapper "this handler can be closed" so we need it.
it's filtered out so user should never see it.
perhaps we should add a clarifying comment instead?
if you are seeing it then something is probably not working right let me review the issue
Member
Clearly we need it as none of us had a clue about it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #31799
I searched in the history about the reason to use 100 as log level, but it seems that it was just for debugging, where there is no logical need to log an error here, sine we need to stop the trigger after each run.
This line was added by #29482 which restored #27758
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.