Bring back unicodecsv as depenendency of Airflow #31814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
dstandish,
ephraimbuddy,
jedcunningham,
pierrejeambrun and
uranusjr
eladkal
approved these changes
Jun 9, 2023
Removing unicodescv as dependency invites problems when users will use older hive, google, microsoft providers, because they were using unicodecsv, but they did not declare it as dependency (it was a transitive dependency of the "apache-airflow" package). It has been removed in apache#31693 Unicodecsv has very low footprint so this is not a problem to keep it. The dependency misses license in it's package, therefore we add the licence in our "licences" folder.
potiuk
force-pushed
the
add-back-unicodecsv
branch
from
2122250 to
5ef4be1
Compare
ephraimbuddy
approved these changes
Jun 9, 2023
eladkal
added
the
type:misc/internal
potiuk
added a commit
that referenced
this pull request
Jun 9, 2023
Removing unicodescv as dependency invites problems when users will use older hive, google, microsoft providers, because they were using unicodecsv, but they did not declare it as dependency (it was a transitive dependency of the "apache-airflow" package). It has been removed in #31693 Unicodecsv has very low footprint so this is not a problem to keep it. The dependency misses license in it's package, therefore we add the licence in our "licences" folder. (cherry picked from commit a853233)
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unicodescv as dependency invites problems when users will use older hive, google, microsoft providers, because they were using unicodecsv, but they did not declare it as dependency (it was a transitive dependency of the "apache-airflow" package).
It has been removed in #31693
Unicodecsv has very low footprint so this is not a problem to keep it.
The dependency misses license in it's package, therefore we add the licence in our "licences" folder.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.