-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add realtime container execution logs for BatchOperator #31837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
Note that we have some other changes in flight right now touching the same code (#31824) CC @vandonr-amz |
|
I did not make any changes to the TaskLogFetcher logic. Since I had to reuse the same LogFetcher without any change I just moved it to |
I think it's fine for everyone to proceed as normal and the second person to merge will have to rebase. I just wanted everyone to be aware of each other's changes. The behaviour of the log fetcher is changing. |
|
Ok. I will wait for any further comments/changes. |
d10bf5c to
17585db
Compare
|
I have updated the changes from #31824 @o-nikolas |
Thanks! Unfortunately there are some more conflicts due to some more logging PRs being merged |
17585db to
c1c32c3
Compare
I have updated the PR |
vandonr-amz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c1c32c3 to
09bfb4b
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
closes: #31675
A new utility called
AWSTaskLogFetcherhas been implemented to address the common functionality shared byEcsTaskLogFetcherinEcsRunTaskOperatorand for theBatchOperatorfor this issue.