Skip to content

Conversation

@killua1zoldyck
Copy link
Contributor

closes: #31675

A new utility called AWSTaskLogFetcher has been implemented to address the common functionality shared by EcsTaskLogFetcher in EcsRunTaskOperator and for the BatchOperator for this issue.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Jun 11, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 11, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@o-nikolas
Copy link
Contributor

Note that we have some other changes in flight right now touching the same code (#31824) CC @vandonr-amz

@killua1zoldyck
Copy link
Contributor Author

I did not make any changes to the TaskLogFetcher logic. Since I had to reuse the same LogFetcher without any change I just moved it to utils/task_log_fetcher.py. Shall I wait for #31824 to get approved and merge that with my changes and update this PR?

@o-nikolas
Copy link
Contributor

I did not make any changes to the TaskLogFetcher logic. Since I had to reuse the same LogFetcher without any change I just moved it to utils/task_log_fetcher.py. Shall I wait for #31824 to get approved and merge that with my changes and update this PR?

I think it's fine for everyone to proceed as normal and the second person to merge will have to rebase. I just wanted everyone to be aware of each other's changes. The behaviour of the log fetcher is changing.

@killua1zoldyck
Copy link
Contributor Author

Ok. I will wait for any further comments/changes.

@killua1zoldyck
Copy link
Contributor Author

I have updated the changes from #31824 @o-nikolas

@o-nikolas
Copy link
Contributor

I have updated the changes from #31824 @o-nikolas

Thanks! Unfortunately there are some more conflicts due to some more logging PRs being merged

@killua1zoldyck
Copy link
Contributor Author

I have updated the changes from #31824 @o-nikolas

Thanks! Unfortunately there are some more conflicts due to some more logging PRs being merged

I have updated the PR

Copy link
Contributor

@vandonr-amz vandonr-amz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-nikolas o-nikolas merged commit e01ff47 into apache:main Jun 19, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 19, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Batch Operator: Realtime container execution logs in Airflow task execution log

4 participants