Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jun 11, 2023

The recent version of pytest released on June 10th introduced change that it will read conftest tests starting in the directory which is current working directory, this causes breeze tests run with working directory being top airflow directory to fail because it's requirements do not contain a few libraries that are used in airflow's conftest.py

This change rather than specifying directory at pytest command line, changes working directory for the tests.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The recent version of pytest released on June 10th introduced
change that it will read conftest tests starting in the directory
which is current working directory, this causes breeze tests run
with working directory being top airflow directory to fail because
it's requirements do not contain a few libraries that are used
in airflow's conftest.py

This change rather than specifying directory at pytest command
line, changes working directory for the tests.
@potiuk potiuk merged commit 3206719 into apache:main Jun 11, 2023
@potiuk potiuk deleted the change-working-directory-for-breeze-unit-tests branch June 11, 2023 08:12
@eladkal eladkal added this to the Airlfow 2.6.3 milestone Jun 11, 2023
@eladkal eladkal added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jun 11, 2023
potiuk added a commit that referenced this pull request Jun 11, 2023
The recent version of pytest released on June 10th introduced
change that it will read conftest tests starting in the directory
which is current working directory, this causes breeze tests run
with working directory being top airflow directory to fail because
it's requirements do not contain a few libraries that are used
in airflow's conftest.py

This change rather than specifying directory at pytest command
line, changes working directory for the tests.

(cherry picked from commit 3206719)
@potiuk potiuk modified the milestones: Airlfow 2.6.3, Airflow 2.6.2 Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants