Deprecate wait_for_completion from EcsRegisterTaskDefinitionOperator and EcsDeregisterTaskDefinitionOperator
#31884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
those operations are actually completed instantly. the doc to deregister says it explicitely: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/deregister-task-definition.html > When you deregister a task definition revision, it’s immediately marked as INACTIVE. to register a task, it's less clear, but task definition states show no transition states https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-definition-state.html and expriments show that the task is always returned as active right after having been created.
boring-cyborg
bot
added
area:providers
provider:amazon
eladkal
reviewed
Jun 14, 2023
vincbeck
approved these changes
Jun 16, 2023
eladkal
approved these changes
Jun 16, 2023
eladkal
changed the title
wait_for_completion from EcsRegisterTaskDefinitionOperator and EcsDeregisterTaskDefinitionOperator
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
those operations are actually completed instantly.
the doc to deregister says it explicitely:
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/deregister-task-definition.html
to register a task, it's less clear, but task definition states show no transition states https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-definition-state.html and expriments show that the task is always returned as active right after having been created.