Skip to content

Conversation

@enchant3dmango
Copy link
Contributor

@enchant3dmango enchant3dmango commented Jun 16, 2023

There is no spark_conn_id in the SparkSubmitOperator, there is a conn_id for the Spark connection.

Screenshot:
image

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 16, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@hussein-awala hussein-awala added the type:doc-only Changelog: Doc Only label Jun 16, 2023
Copy link
Contributor

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👍

@uranusjr uranusjr merged commit 6becb70 into apache:main Jun 16, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 16, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@eladkal eladkal removed the type:doc-only Changelog: Doc Only label Jun 16, 2023
@enchant3dmango enchant3dmango deleted the fix-typo-in-spark-submit-operator-doc branch February 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants