Fix where account url is build if not provided using login (account name) #32082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
kind:documentation
provider:microsoft-azure
Contributor
Author
|
cc @phanikumv |
Adaverse
force-pushed
the
patch-4
branch
2 times, most recently
from
fd2c9d8 to
d622ead
Compare
added extra field in wasb hook
potiuk
approved these changes
Jun 27, 2023
69 tasks
| return BlobServiceClient( | ||
| account_url=f"https://{conn.login}.blob.core.windows.net/{sas_token}", **extra | ||
| ) | ||
| return BlobServiceClient(account_url=f"{account_url}/{sas_token}", **extra) |
Contributor
There was a problem hiding this comment.
This will give incorrect url if account_url ends with a slash e.g:
account_url = https://{conn.login}.blob.core.windows.net/
then here we will end up with:
account_url = https://{conn.login}.blob.core.windows.net//sas_token
Contributor
Author
There was a problem hiding this comment.
Yes, will correct it with patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #31811
Builds account URL for below-mentioned auth methods if account URL is not provided using account name (login)
It helps avoid avoidable error. Doesn't apply to connection string and Azure AD.
Updated docs to reflect the same and implemented test to cover the changes made.
Exposed
extrafield (which was hidden) to incorporate the changes in #31783 which was missed.A sample is provided below
Before -
After -
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.